fix: wisp create --dry-run reports wrong count when rootOnly overridden#2813
Merged
maphew merged 1 commit intosteveyegge:mainfrom Mar 26, 2026
Merged
Conversation
Fixes steveyegge#2725. The --dry-run early return was executing before the rootOnly override logic, causing dry-run to report all N issues would be created while the actual run only creates 1 (root). - Move rootOnly override block above the dryRun check so both paths see the same rootOnly value - Update dry-run output to show '1 issue (root only)' with a note explaining how many child steps were skipped and how to enable them via pour=true in the formula - For pour=true formulas, dry-run still reports all issues as before
harry-miller-trimble
force-pushed
the
fix/wisp-dry-run-root-only
branch
from
cd99e26 to
93d7cff
Compare
Collaborator
|
Thanks @harry-miller-trimble — clean fix, good root cause analysis. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2725 —
bd wisp create --dry-runnow reports the correct issue count whenrootOnlyis overridden (formula withoutpour=true).Problem
The
--dry-runearly return was executing before therootOnlyoverride logic, causing dry-run to report all N issues would be created while the actual run only creates 1 (root only).Changes
cmd/bd/wisp.go— MoverootOnlyoverride block above thedryRuncheck so both paths see the samerootOnlyvalue1 issue (root only)with a note explaining how many child steps were skipped and how to enable them viapour=truein the formulapour=trueformulas, dry-run still reports all issues as beforeChecklist